Add disable=True/False flag for Spark autologging#20
Open
mohamad-arabi wants to merge 24 commits intodbczumar:interf_protofrom
Open
Add disable=True/False flag for Spark autologging#20mohamad-arabi wants to merge 24 commits intodbczumar:interf_protofrom
mohamad-arabi wants to merge 24 commits intodbczumar:interf_protofrom
Conversation
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
…ion tests (mlflow#3800) * skip if the matrix is empty Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * set is_matrix_empty Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix syntax error Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * minor comment fix Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
* Fix for xgboost 1.3.0 Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * do not include 1.3.0 since it has been removed Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * re-run all the tests if set_matrix contains changes Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix regexp Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add test case Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Refactor using packaging Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add packaging Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
dbczumar
reviewed
Dec 12, 2020
| from tests.spark_autologging.utils import file_path # pylint: disable=unused-import | ||
|
|
||
|
|
||
| # Note that the following tests run one-after-the-other and operate on the SAME spark_session |
Owner
There was a problem hiding this comment.
@mohamad-arabi This is awesome! Can we also test the case where there isn't a preexisting spark session and we call autolog() with disable=True/False before creating a session?
Author
There was a problem hiding this comment.
In my opinion that is covered in these 2 test cases:
https://github.com/dbczumar/mlflow/pull/20/files#diff-7e304d4fffb199878e90000a4dd020fb4d8b5b9a046289a55babd3e44314e643R113
and
Owner
There was a problem hiding this comment.
These just test that no exceptions are thrown. They don’t verify that tags are set or not set depending on the disable flag when a session is created after autolog is called. Let me know if you think we already capture that elsewhere
…3682) * Safe Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Keras Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * TF Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fixes Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Some unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * More unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test coverage for safe_patch Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Add public API for autologging integration configs Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove big comment Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Conf tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Mark large Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Whitespace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Blackspace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Rename Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Simplify, will raise integrations as separate PR Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove test_mode_off for now Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Support positional arguments Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstring fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * use match instead of comparison to str(exc) Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Forward args Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Try importing mock from unittest? Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix import mock in statsmodel Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Revert "Fix import mock in statsmodel" This reverts commit a81e810. Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Support tuple Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Address more comments Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Stop patching log_param Signed-off-by: Corey Zumar <corey.zumar@databricks.com> Co-authored-by: Mohamad Arabi <mohamad.arabi@databricks.com>
* reject bool metric value Signed-off-by: Halil Coban <halil.coban@gmail.com> * add comment on why we check for bool Signed-off-by: Halil Coban <halil.coban@gmail.com>
* initial commit Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * Updated tests to refelct new type conversions rules and to make sure we include hin message when necessary. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * fix tests. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * lint. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * fix. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * fix. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * fix. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * minor fix Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * lint Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * revert Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * update Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * Update doc. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * fix. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * fix docs. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * add hint/warning to schema inference Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * Addressed review comments. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com> * Addressed review comments. Signed-off-by: tomasatdatabricks <tomas.nykodym@databricks.com>
…py < 3.0.0 (mlflow#3825) * Fix AttributeError: 'Dataset' object has no attribute 'value' Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix reimport Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * remove print Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
* Add gluon to cross-version-tests Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix version Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix metric import Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * newline Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * fix typo & pylint error Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * use load_parameters Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix import Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix test_gluon_model_export.py Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Add # pylint: disable=import-error Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Fix import position Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * nit Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
* Fix invalid metric issue in statsmodels flavor Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * Introduce _is_numeric Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
* Add fastai to the cross version tests Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> * add sklearn Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
…low#3815) * Safe Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Keras Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * TF Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fixes Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Some unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * More unit tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test coverage for safe_patch Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Add public API for autologging integration configs Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com> Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove big comment Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Conf tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Mark large Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Whitespace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Blackspace Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Rename Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Simplify, will raise integrations as separate PR Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove partial tensorflow Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Updates from utils Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Remove test_mode_off for now Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Support positional arguments Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstring fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * use match instead of comparison to str(exc) Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Forward args Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fixes from mlflow#3682 Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * integration start Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Try importing mock from unittest? Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix import mock in statsmodel Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Mock fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Revert "Fix import mock in statsmodel" This reverts commit a81e810. Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Support tuple Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Address more comments Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Stop patching log_param Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Modules Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Another test, enable test mode broadly Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Black Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Move to fixture Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstring Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Use test mode for try_mlflow_log Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test try_mlflow_log Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docs Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Assert Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Try log keras Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Review comment, add init for tests Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Actually commit the fixtures file... Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Test fixes, lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix, format Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Fix fast.ai Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lintfix Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Docstrings Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Address nit Signed-off-by: Corey Zumar <corey.zumar@databricks.com> * Lint Signed-off-by: Corey Zumar <corey.zumar@databricks.com> Co-authored-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
27 tasks
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
Signed-off-by: Mohamad Arabi <mohamad.arabi@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
(Please fill in changes proposed in this fix)
How is this patch tested?
(Details)
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: Local serving, model deployment tools, spark UDFsarea/server-infra: MLflow server, JavaScript dev serverarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, JavaScript, plottingarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes